Extend VRF resource to use custom templates#120
Open
jgomezve wants to merge 4 commits intoCiscoDevNet:masterfrom
Open
Extend VRF resource to use custom templates#120jgomezve wants to merge 4 commits intoCiscoDevNet:masterfrom
jgomezve wants to merge 4 commits intoCiscoDevNet:masterfrom
Conversation
jgomezve
commented
Feb 2, 2023
| "asn" : "4201020601" | ||
| "vrfIntfDescription" : "" | ||
| "vrfSegmentId" : "50050" | ||
| "vrfName" : "check3" |
Author
There was a problem hiding this comment.
Even if the VRF Name and the VRF Segment ID are inputs of the resource, the values must be set inside the template properties as well. Otherwise Terraform will try to update does values in a subsequent terraform apply. This is because the Read Operataion identifies those keys but the Schema does not have them
Author
There was a problem hiding this comment.
The same applies for the Network Resource in the PR #121
There was a problem hiding this comment.
Got it. This PR is working for me. Tested it out with different scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #111